Fix #90 - whitespace between mixin and !important is optional #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
reviewed
Sep 25, 2017
lib/less-parser.js
Outdated
| @@ -116,7 +116,7 @@ export default class LessParser extends Parser { | |||
|
|
|||
| if (node.selector.indexOf('!important') >= 0) { | |||
| node.important = true; | |||
| node.selector = node.selector.replace(/\s!important/, ''); | |||
| node.selector = node.selector.replace(/\s*!important/, ''); | |||
There was a problem hiding this comment.
shouldn't this regex be /(\s+)?!important/ ?
There was a problem hiding this comment.
That's equivalent, no? We can also use /\s?!important/ but I though it would make sense to eat as much whitespace as possible here
SimenB
reviewed
Sep 30, 2017
lib/less-parser.js
Outdated
| @@ -114,9 +114,9 @@ export default class LessParser extends Parser { | |||
| // eslint-disable-next-line | |||
| delete this.current.nodes; | |||
|
|
|||
| if (node.selector.indexOf('!important') >= 0) { | |||
| if (node.selector.match(/!important/i)) { | |||
There was a problem hiding this comment.
should be .test as you don't care about the result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
Please check one:
This PR:
Hope this looks good to you, I'm no JS nor parser expert