Skip to content

#96 - Add extra check for not adding params from brackets. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2018

Conversation

HauptmannEck
Copy link
Contributor

Hopefully Fixes #96.

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

After looking through the less documentation I have not found any mixin or extend syntax that uses brackets []. The Idea is to not fill params with brackets.

@shellscape
Copy link
Owner

Thanks for the PR! Please allow me some time to sanity check this against a few things before merging.

@shellscape
Copy link
Owner

Looks like it'll work. Cheers 🍻

@shellscape shellscape merged commit ca9e4c0 into shellscape:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants