Skip to content

Handle spaces between variable name and colon #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

davidyorr
Copy link
Contributor

Fixes #92

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

@@ -14,10 +14,21 @@ describe('Parser', () => {
});

it('parses variables with whitespaces between name and ":"', () => {
let root = parse('@onespace : 42;');
const root = parse('@foo : 42; @bar : 35;');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the test conditions have changed, please ad a new test with the new conditions and leave the old test intact

@shellscape shellscape merged commit 943aff7 into shellscape:master Mar 20, 2018
@shellscape
Copy link
Owner

Cheers 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants