Skip to content

Exception thrown on float angle values #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lazd opened this issue Feb 13, 2020 · 4 comments
Closed

Exception thrown on float angle values #106

lazd opened this issue Feb 13, 2020 · 4 comments

Comments

@lazd
Copy link

lazd commented Feb 13, 2020 •
edited
Loading

  • Operating System (or Browser): macOS
  • Node Version: v13.3.0
  • postcss-values-parser Version: 3.11

How Do We Reproduce?

https://repl.it/@lazd/postcss-values-parser-float-angle-values

Expected Behavior

parse(.5deg) and parse(1.5deg) and friends do not throw. See [W3 spec] for all possible angle values https://www.w3.org/TR/css-values-4/#angles.

Actual Behavior

parse(.5deg) and parse(1.5deg) throw <css input>:1:1: Unknown word
@lazd lazd changed the title Exception thrown on float rotation values Exception thrown on float angle values Feb 13, 2020
@lazd
Copy link
Author

lazd commented Feb 13, 2020

Related to #76. Big ups to @bartveneman for the repl.it that made it easy to demonstrate the issue.

@nex3
Copy link
Contributor

nex3 commented Feb 16, 2020

See also #104.

shellscape added a commit that referenced this issue Apr 17, 2020
@shellscape
test: add tests for #106
18c1156
@shellscape
Copy link
Owner

Fixed in #109

@bartveneman
Copy link

Wow, thanks so much @jonathantneal for implementing! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @shellscape @lazd @bartveneman