Skip to content

Add support for unqouted value of Quoted node #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

niksy
Copy link
Contributor

@niksy niksy commented Nov 3, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Please Describe Your Changes

Closes #94.

@niksy niksy changed the title feat: add support for unqouted value of Quoted Add support for unqouted value of Quoted Nov 3, 2020
@niksy niksy changed the title Add support for unqouted value of Quoted Add support for unqouted value of Quoted node Nov 3, 2020
@shellscape
Copy link
Owner

Thanks for opening this PR, and I've very sorry it took me so long to get around to reviewing this. Your change looks good, but we have a few conflicts in it now. To fix the snapshots you probably only have to rerun the tests with the --u flag.

@niksy
Copy link
Contributor Author

niksy commented Feb 11, 2021

@shellscape done!

@shellscape shellscape merged commit 25d2249 into shellscape:master Feb 11, 2021
@shellscape
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide access to the contents of quoted strings
2 participants