feat: double slash comments #51
Conversation
|
PR looks good at first glance 🍺 Super busy day today so please allow me some time to circle back to it. |
|
/cc @shellscape friendly ping |
|
@evilebottnawi thanks, looking |
| @@ -100,7 +217,7 @@ describe('Parser → Comment', () => { | |||
|
|
|||
| fixtures.forEach((fixture) => { | |||
| it(fixture.it, () => { | |||
| let ast = new Parser(fixture.test).parse(), | |||
| let ast = new Parser(fixture.test, { loose: fixture.loose }).parse(), | |||
There was a problem hiding this comment.
so this is the only thing that stands out as questionable. the existing tests should continue to run without loose, the new tests should use loose, but they should be separate. we don't want non-loose tests running under loose.
There was a problem hiding this comment.
@shellscape i don't change any existing comments just add flag to run own comments in loose mode as you can do in other tests with loose
There was a problem hiding this comment.
yeah disregard that, i'm juggling too much at the moment.
|
@shellscape 👍 just wait release to fix problem in |
|
I should be able to release in a few hours. postcss-less will have a patch as well. |
Which issue # if any, does this resolve?
#49
Please check one: