Skip to content

Fix walk proxies #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2018
Merged

Fix walk proxies #54

merged 1 commit into from
May 17, 2018

Conversation

jonathantneal
Copy link
Collaborator

Which issue # if any, does this resolve?

Resolves #53

Please check one:

  • New tests created for this change
  • Tests updated for this change

@jonathantneal jonathantneal requested a review from shellscape May 17, 2018 04:39
@shellscape shellscape merged commit b45eebd into shellscape:master May 17, 2018
@shellscape
Copy link
Owner

Thanks for the fix. I'm out of the country until the 26th and without a laptop, so a publish on this is going to be delayed.

@jonathantneal
Copy link
Collaborator Author

I thought you had given me publish rights, but I now realize it was only repo rights. Regardless, I wanted your review of the code most of all.

It looks like your publish step is to test and bump package.json / package-lock.json, commit that, and npm publish.

I’ll let you make the call: https://www.npmjs.com/package/postcss-values-parser/access

And no worries if you’d like to keep npm access to yourself. 😄

@jonathantneal jonathantneal deleted the fix/walk-proxies branch May 17, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API walk* proxies don't work, and here’s how we fix them
2 participants