Skip to content

Add TypeScript typings for the package. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jan 22, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

This adds a .d.ts file describing the static types of the package's API.

@nex3 nex3 changed the title This PR contains: Add TypeScript typings for the package. Jan 22, 2020
@nex3 nex3 requested a review from shellscape January 22, 2020 00:38
@nex3
Copy link
Contributor Author

nex3 commented Jan 24, 2020

I think the CI failure is due to upstream dependency vulnerabilities that are unrelated to this PR.

@shellscape
Copy link
Owner

@nex3 please merge upstream/master and that should correct CI

@nex3
Copy link
Contributor Author

nex3 commented Jan 28, 2020

Done.

@shellscape shellscape merged commit 6b891ea into shellscape:master Jan 28, 2020
@shellscape
Copy link
Owner

thanks!

@nex3 nex3 deleted the typings branch January 28, 2020 19:41
@nex3
Copy link
Contributor Author

nex3 commented Jan 28, 2020

Thanks @shellscape! How soon do you expect this to be released?

@shellscape
Copy link
Owner

I usually do a round of publishing at the beginning of the week and near the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants