fix(font-family): use sans-serif instead of sans#62
Merged
sofish merged 1 commit intosofish:masterfrom Feb 6, 2017
Merged
Conversation
sans is not a valid generic font-family, see https://www.w3.org/TR/CSS2/fonts.html#generic-font-families
Owner
|
im not trying to develop a tool that valid but to make a website looks better thanks |
Contributor
Author
|
I am wondering why using |
Owner
|
not because of |
Contributor
Author
|
After browsing on the history I found that |
Owner
|
after a review, i think you are right on this |
Contributor
Author
|
You are very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sans is not a valid generic font-family, see https://www.w3.org/TR/CSS2/fonts.html#generic-font-families