Update enabled flag for IE9 compatibility & preservation of existing cookies#1
Open
ryan-codingintrigue wants to merge 2 commits intosomeshinyobject:masterfrom
Open
Update enabled flag for IE9 compatibility & preservation of existing cookies#1ryan-codingintrigue wants to merge 2 commits intosomeshinyobject:masterfrom
ryan-codingintrigue wants to merge 2 commits intosomeshinyobject:masterfrom
Conversation
Updated enabled check to allow for preexisting cookies to be maintained & IE9 compatibility
Moved `enabled` function to have access to internal methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like the idea of an
enabledproperty for cookies as I do this check myself, but this implementation has a few flaws:navigator.cookiesEnabledalways returns true in IE9document.cookietestvalue is left in the user's cookies if a test succeeds. If you need to check if cookies are enabled, you probably want to check on every load.The suggested replacement uses
$.cookies internal methods for setting a cookie, checking to see if it is set, then removing it again when finished.