Use webpack for build; require in jquery.dropdown.sass as part of plugin #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for submitting this. I haven't played with Webpack yet, so I'm reluctant to start using it before I'm comfortable with it. This plugin definitely needs a better-defined build process, so it will either be this or a Gulp task. I'll leave this PR open for evaluation. |
Collaborator
|
Decided to go with a Gulp task for this. Personal preference really. Follow #118 for progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure what build system was being used prior to this commit, but I've introduced @Webpack in this commit as a means to bundle the CSS (compiled from the Sass file), as well as minifying. Since this is a pretty significant change, I'm happy to have this pull request be dismissed, but I had found it useful as it enabled me to not worry about including both the CSS and Javascript when using the plugin.
Also, great work on this! It's simple and straightforward to use.