Condensed Changes from #38 and a Few Other Things #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function (show()) that takes two arguments—the second being a boolean indicating whether or not it's being called through JavaScript directly. Also, improved code syntax and changed spacing.
… for different functions such as titles, a current selection state (can be reworked to be instant), etc.
Collaborator
|
Please refrain from changing a project's coding conventions. Everyone has their own style and preference, but in order to have your pull request accepted it needs to be easy to review. Changing indentation on every line makes the resulting file difficult to review and may affect the author's workflow. (While there are plenty of passionate discussions about tabs vs. spaces, this isn't the place for it.) That said, you're welcome to submit a new pull request without those modifications. The only other thing I ask is that you discard the minified version and add examples of the new styles in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condensed changes from #38, added and changed some styles, and added a compressed version of the new main file.