Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR to an opensource project, so please let me know if I forgot something! :)
Title
Also sanitizes the injected
list_nameto prevent/characters in this name from creating unwanted directories.Description
called the
sanitize_stringfunction on the injectlist_namebefore replacing{list}or{list[idx]}.Also added a rule to the
sanitize_stringfunction to remove double spaces (created by removing characters).Related Issue
#2284
Motivation and Context
How Has This Been Tested?
I ran the tests on WSL in windows by running
pytestin the cli, and using and extension in vs code.Added a test that calls the
gen_m3u_fileswith a list of songs that have"something / or other"aslist_name.Also tested it manually by downloading a spotify playlist with a
/in the name.Was going to evaluate the test results in GitHub to for other failing tests, because the tests in the master branch also have some failures locally.
Types of Changes
Checklist
Pylint was happy, formatting with black is applied.
For mypy, the first command ran successfully without errors, but then running just
mypy ./spotdldid give some errors about missing library stubs, did the first command not create them all? Or is there another way to create them all?I don't think any changes altered expected functionality.
I still have some failing tests when running all tests.
Some I could fix with updating yt-dlp to 2025-10-22, but I have not committed this, am I allowed to update these dependencies?
Most remaining failing tests had to do with
CannotOverwriteExistingCassetteExceptionandContentDecodingErrorerrors, which I'm not certain about how to fix.