Fix/song from url missing spotify fields#2627
Open
Joelsitovs wants to merge 2 commits intospotDL:masterfrom
Open
Fix/song from url missing spotify fields#2627Joelsitovs wants to merge 2 commits intospotDL:masterfrom
Joelsitovs wants to merge 2 commits intospotDL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Handle missing optional Spotify metadata in
Song.from_urlDescription
This change makes
Song.from_url()more defensive when Spotify returns partialmetadata for a track.
The current implementation assumes that fields such as
genres,label,images,and
popularityare always present in the Spotify API response. In practice, somevalid tracks omit one or more of these optional fields, which causes
spotdlto raiseKeyErrorand abort.This patch replaces those direct dictionary accesses with safe defaults so valid
tracks can still be processed.
Related Issue
Related to the open issue reporting a
KeyErrorinSong.from_url()when Spotifymetadata omits fields like
genres.#2619
Motivation and Context
How Has This Been Tested?
Spotify metadata responses are not always complete for every track.
Because
Song.from_url()treats several optional fields as required,spotdlcanfail on otherwise valid Spotify track URLs. This patch makes the parsing more robust
and prevents crashes caused by missing optional metadata.
Screenshots (if appropriate)
Types of Changes
Checklist