fix(song): handle missing genres in metadata#2630
Open
BillionClaw wants to merge 1 commit intospotDL:masterfrom
Open
fix(song): handle missing genres in metadata#2630BillionClaw wants to merge 1 commit intospotDL:masterfrom
BillionClaw wants to merge 1 commit intospotDL:masterfrom
Conversation
Fix KeyError when Spotify API doesn't return genres for albums or artists. Use .get() with empty list default instead of direct key access. Fixes spotDL#2619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2619
Problem
When the Spotify API doesn't return
genresfor albums or artists, spotDL crashes withKeyError: 'genres'.This happens because the code directly accesses
raw_album_meta["genres"]andraw_artist_meta["genres"]without checking if these keys exist.Solution
Use
.get("genres", [])instead of direct key access to safely handle cases where genres data is missing from the API response.Changes
spotdl/types/song.py: Changedraw_album_meta["genres"] + raw_artist_meta["genres"]toraw_album_meta.get("genres", []) + raw_artist_meta.get("genres", [])This follows the same pattern used elsewhere in the codebase (e.g., line 111 for
album_type, line 125 forisrc).