Use writeFileSync to write to out file #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a write stream, the target file would be erased each time css-extract started. This meant that, when using livereload with CSS, there were two visible reloads: once at the start of css-extract, and once when it finished. Using writeFileSync, the file is only edited once in place.
Current coverage is
|
Contributor
|
This sounds quite reasonable to me. @hughsk what's your take on this? |
Member
|
@yoshuawuyts I reckon let's merge for now to avoid bugs and look into supporting non-inline syntax when we can :) |
Member
|
Oops, wrong issue! This looks good all the same :D |
Contributor
|
💯 excellent! I'll resolve the merge conflicts and merge |
Contributor
|
Published as |
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a write stream, the target file is erased when css-extract starts.
This means that when using livereload with CSS, there are two visible
reloads: once at the start of css-extract with a blank css file, and once
when it finishes with the expected result.
Using writeFileSync, the file is only edited once in place.