Skip to content

Conversation

@ajoslin
Copy link
Contributor

@ajoslin ajoslin commented Mar 25, 2016

As discussed in #3.

You'll notice I didn't use a normal bundle.transform here.

I did that because we need to guarantee that extract-css runs last, after all css and javascript has been compiled. Transforms added through plugins are actually run first.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #4 into master will not affect coverage as of a5f5c88

@@            master      #4   diff @@
======================================
  Files            1       1       
  Stmts           39      30     -9
  Branches         0       0       
  Methods          0       0       
======================================
- Hit             39      30     -9
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of a5f5c88

Powered by Codecov. Updated on successful CI builds.

@ahdinosaur
Copy link
Member

looks good to me. 👍


// run before the "label" step in browserify pipeline
// this makes sure insert-css requires are found before plugins like bundle-collapser run
bundle.pipeline.get('label').unshift(through.obj(write, flush))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I'm missing the context, but we should probably discuss this change and its implications in a separate issue if we haven't already :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm cool with discussing in a separate PR if that means we can land the rest of the patch right now

@hughsk hughsk merged commit 8bde190 into stackcss:master Mar 27, 2016
@hughsk
Copy link
Member

hughsk commented Mar 27, 2016

🎉 thanks @ajoslin! I'll be pushing some style tweaks (to avoid the use of .bind(), and to use .pipe() rather than writing to streams directly) then will publish :)

@ajoslin
Copy link
Contributor Author

ajoslin commented Mar 27, 2016

Perfect, good changes, thank you. I'll open an issue/PR soon about the debug vs label stage in the pipeline.

@ajoslin ajoslin deleted the static-module branch February 26, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants