-
Notifications
You must be signed in to change notification settings - Fork 138
Improve resize on tooltip content change - use appropriate corner to pin tooltip, depending on gravity #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is on the to-do. Thanks for creating the issue! |
I've started working on this, and it has become apparent that using the Because of the static position of the This means that if anyone sets the position on the Styling the I'm debating whether this is worth the risk. |
Got your point. Honestly, i'm not enougth competent, to guarantee good solution without risks. I think, it's better to postpone this issues to next milestone. May be, after 1-2 months we'll get better ideas, or someone with stronger experiance will decide to help. |
I decided to change northern tooltips (n, ne, nw, ne-alt, and nw-alt) to use bottom position after all. Tooltip placement is already vulnerable to problems if people set the This task has been completed. |
No problems. Steven, when do you plan tp release 1.2.0 ? I'd like to synk my codebase with latest version from bower |
@puzrin Soon. I'll probably tag and release it either today or tomorrow. Also, since you're using bower I should let you know: The component that Bower will pull for version 1.2.0 won't include built or minified files. You'll have to See the discussion in issue #54 for more. |
That's ok. I need unpacked file indeed. Our project uses Mincer to care automatically about minification. So, bower is used to manage clienside scripts, like npm manages serverside. I know, that bower is not ideal, but it's much better than nothing :) |
@puzrin Well the PowerTip source code is split up into several files in the src folder, but you should be able to work around that. Let me know if you run into any problems and I'll be happy to offer any help I can. And I do want PowerTip to work correctly with Bower. That project has a lot of potential, it just doesn't support projects structured like PowerTip (or jQuery). I should be able to fix PowerTip for Bower installs once Bower 0.9 is released. |
As requested in stevenbenner#151 referencing issue stevenbenner#31 for rationale
As requested in stevenbenner#151 referencing issue stevenbenner#31 for rationale
As requested in stevenbenner#151 referencing issue stevenbenner#31 for rationale
As requested in stevenbenner#151 referencing issue stevenbenner#31 for rationale
This issue is followup to #27.
Pinning point should be selected, depending on popover location. Then, if content grows, popover will change in proper direction without additional position recalulation.
1. Use-case for corners:
We load content in 2 stages:
If popup grows on second step, then it overlap link (now). So, now we have to call recacculation, to move it up. But if you pin popup with bottom left corner, then it will automatically extend in proper direction (up and right).
IMHO, in practice, it would be very convenient to select "proper" pinned corner for each gravity option. Then it will change inproper direction without additional JS call.
2. Comments about side-placed (left-right-top-bottom) popups:
For side-placed tooltip there are no unique pinning solution. But it's limited to 2 possible choices, instead of 4. I don't have strong opinion, how to choose the best corner of 2.
IMHO, rigth now you can select any of 2, and if someone will have the real case in practice, then you could improve it. IMHO, if someone have top or bottom placed popup, he will fix width. Then content change will only affect height - no problem.
The text was updated successfully, but these errors were encountered: