Added function converting px to em#143
Merged
stubbornella merged 1 commit intostubbornella:oocss-sassfrom Dec 5, 2012
Merged
Conversation
Collaborator
Author
|
@stubbornella Can you review this px to em pull request please? :) |
stubbornella
added a commit
that referenced
this pull request
Dec 5, 2012
Added function converting px to em
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a function in utils for converting px to em. I'm not sure if that's the right place to put it as I worry people might get confused that it is a mixin when they see
@import pxToEmin thescreen.scss. Maybe we can put it in another folder? Or name it differently?Example of how to use it: