Update _pxToEm.scss#163
Merged
mobywhale-chan merged 1 commit intostubbornella:masterfrom Jul 9, 2013
MrFjords:patch-1
Merged
Conversation
Added a check for if the value 'auto' is passed to the function to deal with cases where auto is desired as an output. for example: margin: pxToEm(20px auto, 16px); would output -> margin: 1.25em auto;
Owner
|
@mobywhale-chan can you code review this PR? |
Collaborator
|
@MrFjords Looks good. Thanks! |
|
You might also want to use percentage based or other values. in my px to rem mixin over here. It might be interesting to use a mixin like that for |
Contributor
Author
|
If I've needed to use percentages along with ems I tend to go with something like this: margin: pxToEm(20px, 16px) percentage(20px/$widthOfContent); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for if the value 'auto' is passed to the function to deal with cases where auto is desired as an output. for example:
margin: pxToEm(20px auto, 16px); would output -> margin: 1.25em auto;