Support <label><input></label> style for checkboxes and radio buttons#184
Open
mbrowne wants to merge 6 commits intostubbornella:masterfrom
Open
Support <label><input></label> style for checkboxes and radio buttons#184mbrowne wants to merge 6 commits intostubbornella:masterfrom
mbrowne wants to merge 6 commits intostubbornella:masterfrom
Conversation
Author
|
I have now updated the documentation for this as well: |
…n of OOCSS, it seems necessary to run `make bw` manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As posted on the OOCSS forum: https://groups.google.com/forum/#!topic/object-oriented-css/m5m_SbCLoCc
The issue I had was with checkboxes and radio buttons...as long as my HTML was like the examples, it was fine, but sometimes I like to wrap my tag around the checkbox or radio button, e.g.:
And if I want to use the style shown in the docs, I just need to add the hanging-indent class:
If anyone has any other ideas I think it would be good to discuss them, but in any case I think both styles of HTML should be supported.
I'm happy to update the documentation file as well if this pull request is accepted. Thank you.