Skip to content

Support multiple font-variants #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
finnp opened this issue Jan 6, 2023 · 3 comments · Fixed by #176
Closed

Support multiple font-variants #175

finnp opened this issue Jan 6, 2023 · 3 comments · Fixed by #176

Comments

@finnp
Copy link
Contributor

finnp commented Jan 6, 2023

The following:

styled.view`
 font-variant: small-caps oldstyle-nums;
`

should map to

<View style={{fontVariant: ['small-caps', 'oldstyle-nums']}}

It looks like instead it only chooses one of the font-variants provided.
@finnp finnp changed the title Multiple font-variants do not work Support multiple font-variants Jan 6, 2023
@jacobp100
Copy link
Contributor

You're right. Embarrassing too - I implemented fontVariant in react-native 😳😅

If you wanted to take a crack at it, replace this with something like this

@finnp
Copy link
Contributor Author

finnp commented Jan 6, 2023

Haha, nice only saw your comment right now. I actually just finished fixing it. Gonna send a PR now 👍

finnp added a commit that referenced this issue Jan 6, 2023
@finnp
Allow multiple font variant values to be used, fixes #175
2234fe9
@finnp finnp mentioned this issue Jan 6, 2023
Merged
finnp added a commit that referenced this issue Jan 6, 2023
@finnp
Allow multiple font variant values to be used, fixes #175
22d3223
jacobp100 added a commit that referenced this issue Jan 6, 2023
@jacobp100
Merge pull request #176 from styled-components/allow-multiple-font-va…
ce1264c 
…riants

Allow multiple font variant values to be used, fixes #175
@jacobp100
Copy link
Contributor

Published 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow multiple font variant values to be used, fixes #175 styled-components/css-to-react-native
2 participants
@finnp @jacobp100