Handling of line-height with a multiplier value

[kristerkari]

Currently with a multiplier value for line-height:

transformCss([['line-height', '1.5']])

The result is this:

{ lineHeight: 1.5 }

React Native treats it as a pixel value instead of a multiplier. We can only calculate the multiplier if we know the font-size of the Text element.

Maybe we should only allow pixels (or other units) to be used with line-height and throw an error for a multiplier?

ping @jacobp100

[jacobp100]

It’s just going through the generic remove-px route. Maybe we could just warn/throw an exception on dev for this case

[kristerkari]

We could just add this to fix the issue:

const lineHeight = tokenStream =>
  tokenStream.expect(LENGTH, UNSUPPORTED_LENGTH_UNIT)