Skip to content

Border none #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2019
Merged

Border none #104

merged 2 commits into from
May 6, 2019

Conversation

jacobp100
Copy link
Contributor

  • Fixes border: none
  • Removes anyOrderShorthand, as it was only used in two places and only one (border) accepted none
  • Removes the $merge stuff - I just don't like it any more

@jacobp100 jacobp100 requested a review from kristerkari May 6, 2019 10:52
kristerkari
kristerkari approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and removing anyOrderFactory and $merge makes things simpler.

@jacobp100 jacobp100 merged commit 8cc7cfb into master May 6, 2019
@jacobp100 jacobp100 deleted the border-none branch May 6, 2019 12:32
@kristerkari
Copy link
Contributor

Are you also going to release the new patch? :)

@jacobp100
Copy link
Contributor Author

Ahh completely forgot! I'll set myself a reminder to do it tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristerkari kristerkari kristerkari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobp100 @kristerkari