Skip to content

add two unsupported self defined unit for later dynamic px2dp sizing #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

5468sun
Copy link

@5468sun 5468sun commented May 19, 2019

Im using self defined unit pxdp (pixel to Density-independent pixels) and pxfz (pixel to font size) to do dynamic sizing later. but throw exception when packaging. I think we should add this two units or better remove the restrain.

@jacobp100
Copy link
Contributor

Thanks for the PR!

In CSS, pixels are density independent - so you might be able to just use that directly!

I understand we currently support units not available in RN, but I think adding units not available in CSS is possibly a step too far for this project at least. Although you're more than welcome to fork if you need this for your project.

@jacobp100 jacobp100 closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants