Fix border-color only accepting named colors #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobp100
reviewed
Aug 14, 2019
|
Good catch! |
Co-Authored-By: Jacob Parker <jacobparker1992@gmail.com>
|
Any idea why the build's failing? |
Looks like some npm registry error |
|
@jacobp100 I don't know what to do with the broken CI, I tried restarting the build a couple of times, but it always fails with the same error of something being wrong in the tar header of the |
jacobp100
approved these changes
Aug 18, 2019
|
I suspect we just wanna update the packages - we should do that before we ship in case this starts affecting other people |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using rgb/rgba with
border-coloris throwing an error.ping @jacobp100