Skip to content

Resolves #11 by only outputting borderRadius prop #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jh3y
Copy link

@jh3y jh3y commented Nov 24, 2016

Change grammar to only output borderRadius instead of borderTopLeftRadius etc. which doesn't seem to have an effect when developing for native.

One solution could be to output them all together to cover all bases but I'm not sure if this is necessary.

Would be happy to update if you'd rather it included all props though 😄

The tests pass and as stated in my original issue here only using borderRadius works as expected within native and this was the case with styled-components version 1.0.11.

@jh3y

@jacobp100
Copy link
Contributor

It's by design.

border-top-left-radius: 2;
border-radius: 5;

This should give a border top right radius of 5, which is what we get.

It's also worth mentioning that border radius can accept multiple values as a shorthand.

@jacobp100 jacobp100 closed this Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants