Skip to content

Conversation

@jacobp100
Copy link
Contributor

Since we're doing a major release anyway, I want to remove this, as it does the wrong thing in the following case,

const Component = styled(View)`
  font: 16px/1.5 system;
`

const IncorrectLineHeight = () => (
  <Component style={{ fontSize: 24 }} />
)

@jacobp100 jacobp100 requested a review from kristerkari October 3, 2019 20:15
Copy link
Contributor

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@jacobp100 jacobp100 merged commit 26f4b49 into master Oct 4, 2019
@jacobp100 jacobp100 deleted the remove-unitless-lineheight branch October 4, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants