Skip to content

Percentage support #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Percentage support #19

wants to merge 4 commits into from

Conversation

jacobp100
Copy link
Contributor

mxstbr
mxstbr approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we ship this or is it a breaking change?

@jacobp100
Copy link
Contributor Author

Its breaking. It's got the font family stuff, because there would be merge conflicts otherwise.

@jacobp100 jacobp100 closed this Jan 23, 2017
@jacobp100 jacobp100 deleted the percentage-support branch February 20, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobp100 @mxstbr