Skip to content

Values parser #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2017
Merged

Values parser #21

merged 6 commits into from
Jan 24, 2017

Conversation

jacobp100
Copy link
Contributor

@jacobp100 jacobp100 commented Jan 23, 2017

This is a refactor to use postcss-value-parser. This makes it easier to follow spec, and gives a perf boost. In addition, it will probably be easier for people to contribute.

This has all the v2 breaking changes:

  • Require pixel units for lengths
  • Quotes font family prop.

@mxstbr
Copy link
Member

mxstbr commented Jan 23, 2017

FYI, we're switching to stylis.js for the web version of styled-components in v2. No idea what we'll do with ReactNative... (see styled-components/styled-components#286)

Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobp100 jacobp100 merged commit 99d523f into master Jan 24, 2017
@mxstbr mxstbr deleted the values-parser branch January 24, 2017 09:02
@jacobp100
Copy link
Contributor Author

jacobp100 commented Jan 24, 2017

Not too sure there, it looks like we might have to use postCSS on Native so we can get the styles as an object.

For this branch, should be publish it so people can test regressions? If we do that, what’s best? A 2.0.0-pre version, or just 2.0.0?

Also, depending on the v2 timescale, we may want to consider a codemod for the breaking changes.

@mxstbr
Copy link
Member

mxstbr commented Jan 24, 2017

For this branch, should be publish it so people can test regressions? If we do that, what’s best? A 2.0.0-pre version, or just 2.0.0?

Yes let's publish 2.0.0 of css-to-react-native, and submit a PR to the main repo to upgrade it to that version on the v2 branch.

Also, depending on the v2 timescale, we may want to consider a codemod for the breaking changes.

Have you ever done that before? I'd love to have one, that's for sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants