Skip to content

Bugfix/box shadow #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2018
Merged

Bugfix/box shadow #60

merged 3 commits into from
Feb 4, 2018

Conversation

kristerkari
Copy link
Contributor

fixes #59

@kristerkari kristerkari mentioned this pull request Feb 3, 2018
Closed
jacobp100
jacobp100 reviewed Feb 4, 2018
View reviewed changes
src/transforms/boxShadow.js Outdated
tokenStream.matchesFunction() || tokenStream.matches(WORD)
)) {
color = String(tokenStream.lastValue);
} else if (tokenStream.matches(COLOR)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to check color === undefined to stop box-shadow: 0 0 0 red yellow green blue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, should I add a test case for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test case and a fix for that. :)

@jacobp100 jacobp100 merged commit 7beef8f into styled-components:master Feb 4, 2018
@mxstbr
Copy link
Member

mxstbr commented Feb 4, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

@jacobp100
Copy link
Contributor

Perfect! Thanks a lot! 😀

@kristerkari kristerkari deleted the bugfix/box-shadow branch February 4, 2018 13:26
@kristerkari
Copy link
Contributor Author

Great :) Would it be possible to get a new patch release with these changes?

@jacobp100
Copy link
Contributor

I’ll do it tonight. I wanna get some token stream perf improvements in too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobp100 jacobp100 jacobp100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boxShadow transform does not support rbg, rgba, hsl or hsla colors
3 participants
@kristerkari @mxstbr @jacobp100