Improve tokenstream performance, implement prettier #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be great to copy the prettier config from the main repo+add lint-staged. We should also add CI to this repo?! |
|
Is your |
mxstbr
approved these changes
Feb 4, 2018
kristerkari
approved these changes
Feb 4, 2018
|
Sorry about that, I'm so used to it, I didn't realise this project didn't have it already when doing the changes! Published v2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves tokenstream performance by removing all calls to
[].slice. See my comments at #61. All tests pass.Sorry, I didn't realise I had turned prettier on until I was mostly through this. Added it as a dev dependency—we should use it here from now on! @mxstbr did you want to change the prettier config to match the rest of the projects?