Skip to content

Add support for the text-decoration property #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Add support for the text-decoration property #63

merged 1 commit into from
Feb 7, 2018

Conversation

mchudy
Copy link
Member

@mchudy mchudy commented Feb 6, 2018

Adds support for the text-decoration property. Implemented separately because of the tricky case, in which text-decoration-line can be set both to underline and line-through (which is supported by RN).

Copy link
Contributor

@jacobp100 jacobp100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I’ll merge this tonight. Thanks! 😄

@jacobp100 jacobp100 merged commit f91597d into styled-components:master Feb 7, 2018
@mxstbr
Copy link
Member

mxstbr commented Feb 7, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants