Improve spec compliance for text-decoration #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristerkari
reviewed
Feb 8, 2018
src/transforms/textDecoration.js
Outdated
| ) { | ||
| lines.push(tokenStream.lastValue) | ||
| if (lines[0] === lines[1]) { | ||
| throw new Error('Expected two different text decoration line styles') |
There was a problem hiding this comment.
What about adding a test for this error?
There was a problem hiding this comment.
Huh. Not even sure why I added that. I should probably just let RN handle the invalid values
There was a problem hiding this comment.
Well, to me it seems a bit weird that some CSS parsing errors are thrown by css-to-react-native and others go all the way to RN. Of course in both cases the user will see the error.
There was a problem hiding this comment.
I think maybe the cut-off should be is if the parsing is ambiguous or incomplete we throw an error, otherwise let RN do it.
|
Oh yeah there is still the ongoing discussion about reordering values in the other PR, so if something is changed there it needs to be changed here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.