Implement text shadow, unify text & box shadow, improve spec complian… #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristerkari
reviewed
Feb 9, 2018
| }) | ||
|
|
||
| it('textShadow omitting color', () => { | ||
| expect(transformCss([['text-shadow', '10px 20px black']])).toEqual({ |
There was a problem hiding this comment.
The test description says omitting color but the test is the same as previous with a different color, is this correct?
kristerkari
reviewed
Feb 9, 2018
| }) | ||
|
|
||
| it('textShadow omitting blur, offset-y', () => { | ||
| expect(transformCss([['text-shadow', '10px 20px red']])).toEqual({ |
There was a problem hiding this comment.
also this test seems to be the same as previous ones.
There was a problem hiding this comment.
Another good catch, this should be removed
kristerkari
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce, begin new test layout
Fixes #69