Skip to content

Fix #98 and remove package-lock.json #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2018

Conversation

kopax
Copy link

@kopax kopax commented Nov 30, 2018

This fix:

@kopax kopax changed the title Fix #98 and remove package-lock.json Fix #95 and remove package-lock.json Nov 30, 2018
@kopax kopax changed the title Fix #95 and remove package-lock.json Fix #98 and remove package-lock.json Nov 30, 2018
@jacobp100
Copy link
Contributor

jacobp100 commented Nov 30, 2018

Could you update the yarn lock file? 😀

(I think you can just run yarn to do it)

@kopax
Copy link
Author

kopax commented Nov 30, 2018

$ yarn
bash: yarn: command not found
$ npx yarn
npx: installed 1 in 5.468s
yarn install v1.12.3
# ... zzz
To github.com:kopax/css-to-react-native.git
   c62fdfb..5bb1433  master -> master

All good

@@ -1,2 +1,3 @@
/node_modules
/index.js
/package-lock.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed when you have package-lock=false in .npmrc?

Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it @jacobp100?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants