Skip to content
This repository was archived by the owner on Feb 9, 2023. It is now read-only.

Add CI #19

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Add CI #19

merged 2 commits into from
Apr 3, 2020

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 3, 2020

Which issue, if any, is this issue related to?

Closes https://github.com/stylelint/postcss-css-in-js/issues/10

Is there anything in the PR that needs further explanation?

Fires-up the CI. I will standardise the tooling (ESLint etc) in a follow up pull request once #17 and #18.

We should merge this and then rebase the other two pull requests.

We should merge this and then rebase the nested literals fix.

@jeddy3
Copy link
Member Author

jeddy3 commented Apr 3, 2020

The tests aren't passing on Windows. Is this a blocker to release?

@ota-meshi
Copy link
Member

ota-meshi commented Apr 3, 2020

Hi.

I think you probably need to do the following:

git config --global core.autocrlf false

https://github.com/actions/checkout/issues?q=is%3Aissue+is%3Aopen+autocrlf

@jeddy3
Copy link
Member Author

jeddy3 commented Apr 3, 2020

I think you probably need to do the following:

Good shout. All green now.

@jeddy3 jeddy3 merged commit 9d729fe into master Apr 3, 2020
@jeddy3 jeddy3 deleted the add-ci branch April 3, 2020 11:26
@hudochenkov
Copy link
Member

Why do we need to test it on all OSes? I believe all code is platform independent and there is no file operations.

@jeddy3
Copy link
Member Author

jeddy3 commented Apr 3, 2020

Why do we need to test it on all OSes?

We probably don't. I was just copy-pasting the standard CI tasks so I didn't have to think about it.

@hudochenkov hudochenkov mentioned this pull request Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Setup continuous integration
3 participants