This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Use shared configs #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad1a5b3 to
d2b4242
Compare
|
This is ready for review. I've turned off the conflicting ESLint rules for now, and I'll create a follow-up issue to enable them. I don't know the codebase well enough to make the changes in this pull request, and I don't want that to delay getting this merged. |
hudochenkov
approved these changes
Apr 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows https://github.com/stylelint/postcss-css-in-js/issues/12
I'm out of time for today, but there are a handful of ESLint errors remaining.
Feel free to pull down and amends this pull request, if you have time.