Upgrade easy import #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This offers more robust checks and is unit tested separately.
1f5e2c2 to
e106291
Compare
giuseppeg
reviewed
Apr 18, 2017
| @@ -111,16 +114,17 @@ function mergeOptions(options) { | |||
| options = options || {}; | |||
| const mergedOpts = assign({}, defaults, options); | |||
| const easyImportOpts = mergedOpts['postcss-easy-import']; | |||
| const origTransform = easyImportOpts.transform; | |||
There was a problem hiding this comment.
should we add a warning here so that we can avoid a major release?
if (easyImportOpts.transform && !easyImportOpts.load) {
console.warn('Suitcss uses `postcss-easy-import` v2 which renames `transform` to `load`')
}There was a problem hiding this comment.
Why avoid a major? I think the removal of transform would require one anyway. And potentially the upgrade of the stylelint config too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long overdue #72