import events from html5 menus

[jzelenkov]

takes everything what @jbinary has done in #137 and adds improvements mentioned by @rodneyrehm

[jzelenkov]

just realized that my text editor removed all trailing spaces. Should I reintroduce them back?

@rodneyrehm dom event types are listed in array. String was way too long. Multiline string generated new empty string array elements for each identation. And having string concatenation looked even worse.

[jzelenkov]

list of DOM event types taken from here: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects

[rodneyrehm]

Nice! I think I wouldn't go with a static list of events, but rather do something along the lines of

var eventNames = Object.keys(node)
  .filter(function(propertyName){ return propertyName.slice(0, 2) === 'on'; })
  .map(function(propertyName){ return propertyName.slice(2) });

(yes, I'd roll the filtering, mapping and event-registration into one loop, this is for illustration only. Same goes for Object.keys())

[jzelenkov]

@rodneyrehm Cool! I like your suggestion! Just a sec

[jzelenkov]

@rodneyrehm according to W3C spec all html elements must support these event types. I think it would make more sense to do something like this:

defaults = {
   ...
   domEventTypes: getSupportedDomEventTypes()
}

and reuse that array within get_events() rather than recreating it every time. getSupportedDomEventTypes would contain your suggested code

[jzelenkov]

@rodneyrehm event types differ a lot between browsers: chrome, firefox, ie9. Shall we keep it the same way or use a list events from W3C?

[rodneyrehm]

I'd only bind the events a browser understands… so I'd stick with detection rather than static list.

[jzelenkov]

OK. Let me know if you think anything else should be changed

[jzelenkov]

@rodneyrehm What needs to be done for this PR to be accepted?

[rodneyrehm]

time to merge and test the stuff

[jzelenkov]

OK

[rodneyrehm]

My time is extremely short. If you're interested in taking over the lead of this plugin for a while, we can talk about giving you the necessary privileges - contact me at mail at rodneyrehm dot de if you're interested