Skip to content

Add demo for promise-based context menu in text input #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbrala merged 2 commits into from
Aug 24, 2021
Merged

Add demo for promise-based context menu in text input #734

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8631fa2
Add demo for promise-based context menu in text input
Sep 21, 2020
59fec3a
Remove mouseup handler in demo/menu-promise
Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove mouseup handler in demo/menu-promise
  • Loading branch information
Eric Prud'hommeaux committed Sep 21, 2020
commit 59fec3a2d14373ca207549e490a38ac574f719f5
11 changes: 1 addition & 10 deletions documentation/demo/menu-promise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,9 @@ currentMenu: menu-promise

// right-click handler enables mouseup handler
function rightClickHandler (e) {
e.preventDefault();
const $this = $(this)
$this.on('mouseup', mouseUpHandler);
$this.off('contextmenu', rightClickHandler)
}

// on mouseup, wait for the menu items and paint a context menu
function mouseUpHandler (e) {
e.preventDefault();
const $this = $(this);
$this.off('mouseup', mouseUpHandler);
$this.off('contextmenu', rightClickHandler);

// when the items are ready,
buildMenuItemsPromise().then(items => {
Expand All @@ -89,7 +81,6 @@ currentMenu: menu-promise

$this.on('contextmenu', rightClickHandler)
});
return false
}

// callback insert letters over the selection
Expand Down