Skip to content

removed e.stopPropagation call in keyStop function #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

removed e.stopPropagation call in keyStop function #98

wants to merge 1 commit into from

Conversation

coderaiser
Copy link
Contributor

Hi, first of all I want thank you for good library :).
I am using it in my application and sometime I need to check
is Esc-button presed and do some processing. But becaouse of
stopPropagation function I could not to know about it.
Is it realy necessary? Can we just drop it?
Or exclude in some situations?

Hi, first of all I want thank you for good library :).
I am using it in my application and sometime I need to check
is Esc-button presed and do some processing. But becaouse of
stopPropagation function I could not to know about it.
Is it realy necessary? Can we just drop it?
Or exclude in some situations?
@rodneyrehm
Copy link
Contributor

Hey there,

yes, preventing the default action is required. Pressing the down arrow is supposed to select the next command, but not move the viewport.

We could export all internal event handlers $.contextMenu.handle = handle; to allow you to access the otherwise opaque handlers from the outside: $.contextMenu.handle.keyStop = $.noop;

@coderaiser
Copy link
Contributor Author

Okey, I think it would be the best solution. Thank you.

@rodneyrehm
Copy link
Contributor

superseded by #101 - fixed

@rodneyrehm rodneyrehm closed this Dec 29, 2012
@coderaiser coderaiser deleted the patch-2 branch December 29, 2012 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants