Merged
Conversation
Collaborator
|
I appreciate these commits, but it would be nice to have a PR without so many whitespace changes. I didn't add Compass as an explicit dependency, because I wanted to leave open the possibility of making a Sass plugin as well. If it's causing problems, you can open an issue (or PR) for adding it as a dependency. Not everyone using Compass is using Rails, so I don't think the asset pipeline is a consideration for providing Sass or Compass support. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed input outline colour.
On a side note, you should probably include
compassin your gemspec since it's required. Or better yet, remove the compass dependency altogether and use asset pipeline. :)