Skip to content

Input outline fixes#26

Merged
michaek merged 2 commits intot0m:masterfrom
fredwu:input_outline_fixes
Aug 13, 2013
Merged

Input outline fixes#26
michaek merged 2 commits intot0m:masterfrom
fredwu:input_outline_fixes

Conversation

@fredwu
Copy link
Contributor

@fredwu fredwu commented Aug 13, 2013

Fixed input outline colour.

On a side note, you should probably include compass in your gemspec since it's required. Or better yet, remove the compass dependency altogether and use asset pipeline. :)

@michaek
Copy link
Collaborator

michaek commented Aug 13, 2013

I appreciate these commits, but it would be nice to have a PR without so many whitespace changes.

I didn't add Compass as an explicit dependency, because I wanted to leave open the possibility of making a Sass plugin as well. If it's causing problems, you can open an issue (or PR) for adding it as a dependency.

Not everyone using Compass is using Rails, so I don't think the asset pipeline is a consideration for providing Sass or Compass support.

Thanks again!

michaek added a commit that referenced this pull request Aug 13, 2013
@michaek michaek merged commit 967616f into t0m:master Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants