Skip to content

factorize component frontmatter defaults #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2016
Merged

factorize component frontmatter defaults #129

merged 1 commit into from
Dec 15, 2016

Conversation

sebastienbarre
Copy link
Contributor

@sebastienbarre sebastienbarre commented Dec 13, 2016

Hey folks,
A quick improvement to the build options, trying to address two issues:

  • the options that can be overridden in the component front matter are not documented,
  • the default values for these options are buried inside the templates.

I moved all of them with the rest inside src/build-components-defaults:

  • it is now easier to change these defaults (you can get rid of all your "bodyClass" : "bg-white" for example),
  • they are documented,.
  • you can override them from build.js, the same way you can override the other options,
  • all the defaults have been organized into sub-objects, for clarity.

@sebastienbarre
Copy link
Contributor Author

@mrmrs I also figured out a way to find when a component was first introduced to the repo, using nodegit, and this should be fairly resistant to you moving/renaming components around. This will have to be in another PR, but I will whip out a quick, alternate index page to demonstrate, where components will be ordered by date, most recent first.

@mrmrs mrmrs merged commit 3c1b445 into tachyons-css:master Dec 15, 2016
@sebastienbarre sebastienbarre deleted the screenshot_frontmatter_defaults branch December 15, 2016 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants