Remove gray border around aspect-ratio layouts in Safari and Chrome #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a browser bug in Safari and Chrome that places a gray border around images in
aspect-ratiolayouts. The simplest solution is just to change theimgtag to adivtag. This solves the issue without additional CSS. In this case, theimgtag is not necessary as there is nosrcattribute.To view the problem, open any of the full bleed layout component pages in Chrome or Safari.
To understand the rationale behind this solution, see this StackOverflow discussion.
Thanks to @MartinKavik for finding this solution.