Skip to content

.mega => .f-5 .mtn => .mt0 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olizilla wants to merge 1 commit into from
Closed

.mega => .f-5 .mtn => .mt0 #62

olizilla wants to merge 1 commit into from

Conversation

@olizilla
Copy link

@olizilla olizilla commented Jun 2, 2016 •
edited
Loading

Update usages of .mega and .mtn to use .f-5 and .mt0 respectively.

Line height doc page before

screenshot 2016-06-02 16 17 04

Line height doc page after

screenshot 2016-06-02 17 24 39

@olizilla
.mega => .f-5 .mtn => .mt0
403d304 
Update usages of .mega and .mtn to use .f-5 and .mt0 respectively.
@olizilla
Copy link
Author

olizilla commented Jun 2, 2016

I ran npm run doc to build out the site after making the changes as per the readme. Shout if I need to do anything else to make it merge-worthy.

@olizilla
Copy link
Author

olizilla commented Jun 2, 2016

Also of note, .f-5 isn't a perfect translation of .mega which looks like it used to map to 4rem rather than 5rem, but there isn't a 4rem shorthand I could find so I took a punt on a future with even higher dpi screens and worse eyesight.

@mrmrs
Copy link
Member

mrmrs commented Sep 27, 2016

Apologies for the extreme delay on this. I believe I've got all of these fixes patched in now. Thanks for bringing them to my attention.

@mrmrs mrmrs closed this Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olizilla @mrmrs