Skip to content

Fix typo : "of of" -> "of" #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Fix typo : "of of" -> "of" #64

wants to merge 0 commits into from

Conversation

Thms-Brnrd
Copy link

No description provided.

@lachlanjc
Copy link
Member

Hey there, thanks so much for contributing! The file you edited is the built page for the documentation, so you’ll need to edit the source code of the page first, then generate the built site as well. (We’re working on improving this, but for now it’s a bit of a pain.)

  1. If you haven’t yet cloned the repo onto your computer and run npm install, do that now 😉
  2. Edit src/templates/index.html on your branch, making the correction
  3. Run npm run doc from your terminal
  4. Push back up to this branch and let me know you’ve updated it

Let me know if you need any help, and thanks again! 😀

@Thms-Brnrd
Copy link
Author

Hey! Oops, sorry, I missed the built files explanation in the README...
I hope it's complete this time ! 😉
Thanks for your time and the detailed procedure 😄

@lachlanjc
Copy link
Member

🙌🏻! Thanks so much. I'm going to take another look at this on my computer later, but it should be good to go 😀

@Thms-Brnrd
Copy link
Author

Hi ! Any update on this pull request ? 😉

@lachlanjc
Copy link
Member

Sorry Thomas! This PR looks mergeable but when I look at the changes tab, it looks like you force-pushed and something went wrong. Could you take a look into that? Thanks :)
image

@Thms-Brnrd Thms-Brnrd closed this Jun 26, 2016
@Thms-Brnrd
Copy link
Author

Sorry, I tried to solve this problem but closed the PR by mistake. I preferred to create a clean new one here : #65. I hope it will be fine this time, and sorry for the mess here...

@lachlanjc
Copy link
Member

@Thms-Brnrd don't worry about it dude! everything's good and thanks for helping out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants