Skip to content

Conversation

@Kikobeats
Copy link

Preview:

screen shot 2016-09-15 at 16 52 22

screen shot 2016-09-15 at 16 57 39

@Kikobeats
Copy link
Author

Incredible, I have a typo in that as usual.

Fixed (not on screen obv 😄 )

Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! 2 things:

  • The indentation/whitespace is a bit off
  • You should make the changes to the file inside src/, then run npm start from your terminal. This file is what gets generated by the build process, so otherwise future changes will overwrite it.

Thanks!

@mrmrs
Copy link
Member

mrmrs commented Sep 26, 2016

Thanks for the pull request but not looking to add a header here for this component, just meant to have logo/mark so going to close this out.

@mrmrs mrmrs closed this Sep 26, 2016
@Kikobeats Kikobeats deleted the patch-1 branch September 26, 2016 13:13
@Kikobeats
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants