Skip to content

Make rings configurable #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TheDevMinerTV
Copy link

@TheDevMinerTV TheDevMinerTV commented Oct 9, 2023

Hey 👋

I've made the changes needed to make rings disableable (is that a word?) since it's been super annoying to just slap focus:ring-0 onto every <input> since I generally don't use rings in my applications. They're also super annoying to override, for example with checkboxes where it isn't possible to get rid of this behaviour at all (adding focus:outline-none focus:ring-0 to my checkbox doesn't seem to do anything except make the outline white instead of non-existant).

This is an optional flag that can be passed to the plugin initialize function. This makes sure that people updating their packages won't get a surprise when their rings stop existing.

This is related to tailwindlabs/tailwindcss#12143.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 10:30pm

@adamwathan
Copy link
Member

Hey thanks for the PR! Generally we have tried to avoid configuration of this type for this version of the plugin and instead encourage people to make customizations using CSS:

#33 (comment)

So going to say no to this one, but you should be able be able to make the changes you want by just layering some of your own base styles on top of what's provided by the plugin.

@adamwathan adamwathan closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants