Turn off if preflight is off #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do understand that this plugin is meant to be used only in thus cases where reset is needed. But I do believe that plugin should respect the core settings of the tailwind. https://tailwindcss.com/docs/preflight#disabling-preflight This PR is not tested
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey! Going to say no to this for now — if you are disabling Preflight and don’t want this plugin to apply any styles I would expect that you also would just not add the plugin. Preflight to me is the name of a specific set of reset styles and this plugin just adds additional base styles separate from that. Thanks regardless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do understand that this plugin is meant to be used only in thus cases where reset is needed. But I do believe that plugin should respect the core settings of the tailwind. https://tailwindcss.com/docs/preflight#disabling-preflight
This PR is not tested